-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prometheus Remote Write Exporter (2/6) #206
Merged
codeboten
merged 1 commit into
open-telemetry:master
from
open-o11y:1-prometheus-remote-write
Nov 27, 2020
Merged
Add Prometheus Remote Write Exporter (2/6) #206
codeboten
merged 1 commit into
open-telemetry:master
from
open-o11y:1-prometheus-remote-write
Nov 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzfaarQureshi
requested review from
a team,
codeboten and
lzchen
and removed request for
a team
November 23, 2020 23:24
8 tasks
8 tasks
AzfaarQureshi
force-pushed
the
1-prometheus-remote-write
branch
4 times, most recently
from
November 24, 2020 19:56
45f6069
to
4b0b438
Compare
AzfaarQureshi
changed the title
Prometheus Remote Write Exporter (2/7)
Prometheus Remote Write Exporter (2/6)
Nov 24, 2020
AzfaarQureshi
force-pushed
the
1-prometheus-remote-write
branch
from
November 24, 2020 20:45
4b0b438
to
19d2b87
Compare
8 tasks
AzfaarQureshi
force-pushed
the
1-prometheus-remote-write
branch
2 times, most recently
from
November 24, 2020 21:44
429393b
to
249ed32
Compare
8 tasks
AzfaarQureshi
changed the title
Prometheus Remote Write Exporter (2/6)
Add Prometheus Remote Write Exporter (2/6)
Nov 24, 2020
8 tasks
ocelotl
approved these changes
Nov 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes requested, not enough to not approve this PR 👍
...orter-prometheus-remote-write/src/opentelemetry/exporter/prometheus_remote_write/__init__.py
Show resolved
Hide resolved
AzfaarQureshi
force-pushed
the
1-prometheus-remote-write
branch
2 times, most recently
from
November 26, 2020 18:05
2688201
to
cf31639
Compare
8 tasks
AzfaarQureshi
force-pushed
the
1-prometheus-remote-write
branch
3 times, most recently
from
November 27, 2020 18:03
418977a
to
e0a6489
Compare
fix lint changes
AzfaarQureshi
force-pushed
the
1-prometheus-remote-write
branch
from
November 27, 2020 18:04
e0a6489
to
a47a89e
Compare
codeboten
approved these changes
Nov 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is PR 2/6 of adding a Prometheus Remote Write Exporter in Python SDK and address Issue open-telemetry/opentelemetry-python#1302
Part 1/6
👉 Part 2/6
Part 3/6
Part 4/6
Part 5/6
Part 6/6
Type of change
How Has This Been Tested?
TestValidation
intest_prometheus_remote_write_exporter.py
Does This PR Require a Core Repo Change?
Checklist:
Documentation has been updatedcc- @shovnik, @alolita