pymemcache query sanitization #1576
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanthccv
reviewed
Jan 15, 2023
shalevr
reviewed
Jan 15, 2023
instrumentation/opentelemetry-instrumentation-pymemcache/tests/test_pymemcache.py
Outdated
Show resolved
Hide resolved
actually this is a good question, i opened an issue in the spec repository in order to clarify this: |
# Conflicts: # CHANGELOG.md # instrumentation/opentelemetry-instrumentation-pymemcache/tests/test_pymemcache.py
srikanthccv
reviewed
Feb 28, 2023
| @@ -44,6 +44,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ([#1592](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1592)) | |||
| - `opentelemetry-instrumentation-django` Allow explicit `excluded_urls` configuration through `instrument()` | |||
| ([#1618](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1618)) | |||
| - Added query sanitization for pymemcache | |||
| ([#1576](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1576)) | |||
There was a problem hiding this comment.
Move this to Unreleased section
| with tracer.start_as_current_span( | ||
| cmd, kind=SpanKind.CLIENT, attributes={} | ||
| ) as span: | ||
| try: | ||
| if span.is_recording(): | ||
| if not args: | ||
| if not args or sanitize_query: |
There was a problem hiding this comment.
I don't think this is the approach we follow elsewhere. The values get replaced with something like ? or similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a query sanitizer to the Pymemcache instrumentation.
Default False, can be enabled with sanitize_query = True
This will allow users to sanitize the query.
PymemcacheInstrumentor().instrument(sanitize_query=True)Fixes #1546
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist: