Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hook to set custom span name in flask instrumentation #152

Merged
merged 11 commits into from
Nov 18, 2020
Merged

Add hook to set custom span name in flask instrumentation #152

merged 11 commits into from
Nov 18, 2020

Conversation

srikanthccv
Copy link
Member

Addresses #134

@srikanthccv srikanthccv requested review from a team, ocelotl and lzchen and removed request for a team November 6, 2020 04:26
@lzchen
Copy link
Contributor

lzchen commented Nov 9, 2020

CHANGELOG entry?

lzchen
lzchen approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a couple of comments.

@srikanthccv
Copy link
Member Author

CHANGELOG entry?

I missed that, added now.

lzchen
lzchen requested changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment.

lzchen
lzchen requested changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comment

@lzchen lzchen merged commit c8904ce into open-telemetry:master Nov 18, 2020
@srikanthccv srikanthccv deleted the flask-custom-span branch December 5, 2020 18:19
@srikanthccv srikanthccv mentioned this pull request Dec 15, 2020
Closed
nstawski pushed a commit to nstawski/ns-opentelemetry-python-contrib that referenced this pull request May 10, 2023
@c24t
Remove create_span from the API (open-telemetry#290)
033bcdc 
Simplify the API by removing create_span.

Resolves open-telemetry#152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@ocelotl ocelotl Awaiting requested review from ocelotl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srikanthccv @lzchen