-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix enable_commenter functionality #1440
Merged
srikanthccv
merged 13 commits into
open-telemetry:main
from
avzis:fix-enable_commenter-in-sql-alchemy
Dec 6, 2022
Merged
fix enable_commenter functionality #1440
srikanthccv
merged 13 commits into
open-telemetry:main
from
avzis:fix-enable_commenter-in-sql-alchemy
Dec 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/opentelemetry-python-contrib into fix-enable_commenter-in-sql-alchemy
# Conflicts: # CHANGELOG.md
shalevr
approved these changes
Dec 5, 2022
osherv
reviewed
Dec 5, 2022
@@ -49,27 +49,29 @@ def _get_tracer(tracer_provider=None): | |||
) | |||
|
|||
|
|||
def _wrap_create_async_engine(tracer_provider=None): | |||
def _wrap_create_async_engine(tracer_provider=None, enable_commenter=False): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the default parameters here are redundant, since they are always passed from the callee funtions
srikanthccv
approved these changes
Dec 5, 2022
auto-merge was automatically disabled
December 6, 2022 12:26
Head branch was pushed to by a user without write access
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix enable_commenter functionality.
Fixes #1368
Now you can either:
enable_commenter
param,like this:
note: it is important to import the
create_engine
function after callinginstrument()
:Type of change
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Now the tests are covering all 4 cases:
sqlcommenter enabled and disabled, both when instrumenting with engine, and when creating the engine after instrumentation.
test_sqlcommenter_disabled()
test_sqlcommenter_enabled()
test_sqlcommenter_enabled_create_engine_after_instrumentation()
test_sqlcommenter_disabled_create_engine_after_instrumentation()
Does This PR Require a Core Repo Change?
No.