Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for mysql instrumentation using NoOpTracerProvider #1423

Merged
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#1413](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1413))
- `opentelemetry-instrumentation-pyramid` Add support for regular expression matching and sanitization of HTTP headers.
([#1414](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1414))
- Add a test for mysql using NoOpTracerProvider
srikanthccv marked this conversation as resolved.
Show resolved Hide resolved
([#1423](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1423))

### Fixed

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@
import mysql.connector

import opentelemetry.instrumentation.mysql
from opentelemetry import trace as trace_api
from opentelemetry.instrumentation.mysql import MySQLInstrumentor
from opentelemetry.sdk import resources
from opentelemetry.test.globals_test import reset_trace_globals
from opentelemetry.test.test_base import TestBase


Expand Down Expand Up @@ -103,6 +105,22 @@ def test_instrument_connection(self):
spans_list = self.memory_exporter.get_finished_spans()
self.assertEqual(len(spans_list), 1)

@patch("mysql.connector.connect", new=mock_connect)
# pylint: disable=unused-argument
srikanthccv marked this conversation as resolved.
Show resolved Hide resolved
def test_instrument_connection_no_op_tracer_provider(self):
reset_trace_globals()
tracer_provider = trace_api.NoOpTracerProvider()
trace_api.set_tracer_provider(tracer_provider)
srikanthccv marked this conversation as resolved.
Show resolved Hide resolved

MySQLInstrumentor().instrument()
srikanthccv marked this conversation as resolved.
Show resolved Hide resolved
cnx = mysql.connector.connect(database="test")
query = "SELECT * FROM test"
cursor = cnx.cursor()
cursor.execute(query)

spans_list = self.memory_exporter.get_finished_spans()
self.assertEqual(len(spans_list), 0)

@patch("mysql.connector.connect", new=mock_connect)
# pylint: disable=unused-argument
def test_uninstrument_connection(self):
Expand Down