-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prom rw exporter #1359
Merged
srikanthccv
merged 27 commits into
open-telemetry:main
from
Seefooo:update_prom_rw_exporter
Oct 31, 2022
Merged
Update prom rw exporter #1359
srikanthccv
merged 27 commits into
open-telemetry:main
from
Seefooo:update_prom_rw_exporter
Oct 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seefooo
force-pushed
the
update_prom_rw_exporter
branch
from
September 27, 2022 18:41
b7e76eb
to
ce9c090
Compare
- add Tox commands to setup & test the exporter - add the Prometheus Remote Write Proto files & update them. - added a mini-script that wraps the protoc command to regen. them
- Fix some naming issues,add a regex to correct these - Update setup.cfg versions - Update the example app for newer sdk syntax
this would be released as part of 1.13.0
Seefooo
force-pushed
the
update_prom_rw_exporter
branch
from
September 28, 2022 13:20
ce9c090
to
5c2ad66
Compare
- Fix flake8 issues - Correct spelling mistakes (except false positive 'ro' in docker compose) - Updated Changelog. Not sure if this is worthy
aabmass
reviewed
Oct 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR! Just leaving a few comments but overall looks great 😃
exporter/opentelemetry-exporter-prometheus-remote-write/README.rst
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-prometheus-remote-write/README.rst
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-prometheus-remote-write/README.rst
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-prometheus-remote-write/README.rst
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-prometheus-remote-write/proto/generate-proto-py.sh
Show resolved
Hide resolved
exporter/opentelemetry-exporter-prometheus-remote-write/setup.cfg
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-prometheus-remote-write/setup.cfg
Outdated
Show resolved
Hide resolved
...orter-prometheus-remote-write/src/opentelemetry/exporter/prometheus_remote_write/__init__.py
Outdated
Show resolved
Hide resolved
...orter-prometheus-remote-write/src/opentelemetry/exporter/prometheus_remote_write/__init__.py
Show resolved
Hide resolved
...orter-prometheus-remote-write/src/opentelemetry/exporter/prometheus_remote_write/__init__.py
Outdated
Show resolved
Hide resolved
- Update to pyproject.toml & float deps - Update README.rst - Updates to automate pulling & generating protobuf files - Add README for protobuf generation
aabmass
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with just a few changes. Thanks again for contributing :)
exporter/opentelemetry-exporter-prometheus-remote-write/examples/sampleapp.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-prometheus-remote-write/pyproject.toml
Outdated
Show resolved
Hide resolved
...porter-prometheus-remote-write/src/opentelemetry/exporter/prometheus_remote_write/version.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-prometheus-remote-write/tests/conftest.py
Outdated
Show resolved
Hide resolved
...orter-prometheus-remote-write/src/opentelemetry/exporter/prometheus_remote_write/__init__.py
Outdated
Show resolved
Hide resolved
Seefooo
commented
Oct 20, 2022
Seefooo
force-pushed
the
update_prom_rw_exporter
branch
from
October 24, 2022 17:11
9158003
to
4450d3a
Compare
- Was causing issues with other tools. I just ran our formatting tool on the generated files to avoid issues. - add a gitignore here to ensure our mimicked import setup doesn't get committed.
- Cannot fix the syntax failures on 'examples/*' directory tho...
- avoids the pylint issue. This is probably better anyway as the example is focused on setting up an environment to test exporting, rather than providing multiple examples.
Thanks! |
saartochner-lumigo
pushed a commit
to lumigo-io/opentelemetry-python-contrib
that referenced
this pull request
Nov 13, 2022
saartochner-lumigo
pushed a commit
to lumigo-io/opentelemetry-python-contrib
that referenced
this pull request
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #933
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.