-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing RichConsoleExporter to allow for multiple traces at once #1336
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the print
exporter/opentelemetry-exporter-richconsole/src/opentelemetry/exporter/richconsole/__init__.py
Outdated
Show resolved
Hide resolved
With a batch exporter this would make all span originate with the first trace Also it would print any span twice which would make the output a bit difficult to read
abfe476
to
516cfec
Compare
516cfec
to
5d1a735
Compare
Please fix |
b0e28d5
to
3a4084a
Compare
…-contrib into fix/rich-console
Took some back and forth, sorry about that, I did not spend enough on getting the dev environment to work properly as my feature was so simple. Had some similar issue than #1083. Now that all works it should be better. |
List of changes:
This makes the debug of a SDK configuration a bit easier