-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metric instrumentation falcon #1230
Merged
srikanthccv
merged 31 commits into
open-telemetry:main
from
TheAnshul756:metric-instrumentation-falcon
Sep 22, 2022
Merged
Metric instrumentation falcon #1230
srikanthccv
merged 31 commits into
open-telemetry:main
from
TheAnshul756:metric-instrumentation-falcon
Sep 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please update the readme |
lzchen
reviewed
Aug 30, 2022
...on/opentelemetry-instrumentation-falcon/src/opentelemetry/instrumentation/falcon/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
approved these changes
Aug 30, 2022
srikanthccv
suggested changes
Sep 1, 2022
instrumentation/opentelemetry-instrumentation-falcon/tests/test_falcon.py
Outdated
Show resolved
Hide resolved
…eAnshul756/opentelemetry-python-contrib into metric-instrumentation-falcon
…python-contrib into metric-instrumentation-falcon
…python-contrib into metric-instrumentation-falcon
srikanthccv
reviewed
Sep 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Added minor comment about the start marker in two places.
srikanthccv
approved these changes
Sep 22, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1157
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tox -e test-instrumentation-falcon1
tox -e test-instrumentation-falcon2
tox -e test-instrumentation-falcon3
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.