Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging instr hook #1117

Merged
merged 9 commits into from
Jun 9, 2022
Merged

Conversation

nata7che
Copy link
Contributor

@nata7che nata7che commented Jun 2, 2022

Description

Added a hook to the log instrumentation. This enables multiple things such as adding data to log records.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Test A
    Added a hook to the instrumentation and added an attribute to the record in it. made sure the added attribute exists on the record after instrumentation.

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@nata7che nata7che requested a review from a team June 2, 2022 09:54
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Srikanth Chekuri <[email protected]>
@srikanthccv
Copy link
Member

@nozik Should I keep you as co-author? I would encourage just one person to add commits on top unless the original author can't work on this PR anymore.

@nozik
Copy link
Contributor

nozik commented Jun 9, 2022

@srikanthccv You can keep @nata7che as the only author

@srikanthccv srikanthccv merged commit ad15f7b into open-telemetry:main Jun 9, 2022
@nozik nozik deleted the logging_instr_hook branch August 21, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants