Django: Capture custom request/response headers #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the title |
sanketmehta28
changed the title
done |
|
Hi @open-telemetry/python-approvers : please do review this PR |
lzchen
reviewed
Apr 1, 2022
lzchen
reviewed
Apr 1, 2022
| @@ -271,12 +291,27 @@ def process_response(self, request, response): | |||
| if activation and span: | |||
| if is_asgi_request: | |||
| set_status_code(span, response.status_code) | |||
| if span.is_recording() and span.kind == SpanKind.SERVER: | |||
| # asgi_getter inside asgi_collect_custom_response_attributes | |||
There was a problem hiding this comment.
I don't believe you have to explain this reasoning behind this, so I would remove the comments.
lzchen
reviewed
Apr 1, 2022
.../opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware.py
Outdated
Show resolved
Hide resolved
lzchen
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md for django framework
Fixes #913
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added unit tests separately for request and response headers for ASGI and WSGI applications. Also tested it manually by capturing the request and response headers from a instrumented django app for both ASGI and WSGI application
Same test cases for both ASGI/WSGI application
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.