Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix asgi instrumentation default span name #146

Closed
lzchen opened this issue Nov 3, 2020 · 1 comment · Fixed by #418
Closed

Fix asgi instrumentation default span name #146

lzchen opened this issue Nov 3, 2020 · 1 comment · Fixed by #418
Labels
backlog good first issue Good for newcomers instrumentation

Comments

@lzchen
Copy link
Contributor

lzchen commented Nov 3, 2020 •
edited by owais
Loading

Similar to wsgi, the default span name for SERVER spans should be HTTP <method> as outlined by the specs.

Part of #434
@codeboten codeboten transferred this issue from open-telemetry/opentelemetry-python Nov 5, 2020
@github-actions
Copy link

github-actions bot commented Apr 6, 2021

This issue was marked stale due to lack of activity. It will be closed in 30 days.

@owais owais added the good first issue Good for newcomers label Apr 6, 2021
adamantike added a commit to adamantike/opentelemetry-python-contrib that referenced this issue Apr 6, 2021
@adamantike
Fix ASGI instrumentation default span name
9bf7bab 
Fixes ASGI default span name for SERVER spans, to be `HTTP <method>`.

Fixes open-telemetry#146.
@adamantike adamantike mentioned this issue Apr 6, 2021
Merged
6 tasks
adamantike added a commit to adamantike/opentelemetry-python-contrib that referenced this issue Apr 6, 2021
@adamantike
Fix ASGI instrumentation default span name
e34297e 
Fixes ASGI default span name for SERVER spans, to be `HTTP <method>`.

Fixes open-telemetry#146.
adamantike added a commit to adamantike/opentelemetry-python-contrib that referenced this issue Apr 6, 2021
@adamantike
Fix ASGI instrumentation default span name
6bdc9e6 
Fixes ASGI default span name for SERVER spans, to be `HTTP <method>`.

Fixes open-telemetry#146.
adamantike added a commit to adamantike/opentelemetry-python-contrib that referenced this issue May 6, 2021
@adamantike
Fix ASGI instrumentation default span name
2d35496 
Fixes ASGI default span name for SERVER spans, to be `HTTP <method>`.

Fixes open-telemetry#146.
adamantike added a commit to adamantike/opentelemetry-python-contrib that referenced this issue May 25, 2021
@adamantike
Fix ASGI instrumentation default span name
66928d2 
Fixes ASGI default span name for SERVER spans, to be `HTTP <method>`.

Fixes open-telemetry#146.
adamantike added a commit to adamantike/opentelemetry-python-contrib that referenced this issue May 26, 2021
@adamantike
Fix ASGI instrumentation default span name
09e0f47 
Fixes ASGI default span name for SERVER spans, to be `HTTP <method>`.

Fixes open-telemetry#146.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog good first issue Good for newcomers instrumentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ASGI instrumentation default span name adamantike/opentelemetry-python-contrib
3 participants
@owais @codeboten @lzchen