Skip to content

Commit

Permalink
Using semantic convention
Browse files Browse the repository at this point in the history
  • Loading branch information
shalevr committed Feb 7, 2023
1 parent eb5e1dc commit b22f06a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
- 'release/*'
pull_request:
env:
CORE_REPO_SHA: 042d7a7921e25936decd95addf4fb1d30afb88e2
CORE_REPO_SHA: f5fb6b1353929cf8039b1d38f97450866357d901

jobs:
build:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@
from opentelemetry.instrumentation.sqlalchemy.version import __version__
from opentelemetry.instrumentation.utils import unwrap
from opentelemetry.metrics import get_meter
from opentelemetry.semconv.metrics import MetricInstruments
from opentelemetry.trace import get_tracer


Expand Down Expand Up @@ -144,7 +145,7 @@ def _instrument(self, **kwargs):
meter = get_meter(__name__, __version__, meter_provider)

connections_usage = meter.create_up_down_counter(
name="db.client.connections.usage",
name=MetricInstruments.DB_CLIENT_CONNECTIONS_USAGE,
unit="connections",
description="The number of connections that are currently in state described by the state attribute.",
)
Expand Down

0 comments on commit b22f06a

Please sign in to comment.