Skip to content

Commit

Permalink
Correct minor typos in the codebase (#1019)
Browse files Browse the repository at this point in the history
Co-authored-by: Srikanth Chekuri <[email protected]>
  • Loading branch information
rahulgupta92 and srikanthccv authored Mar 23, 2022
1 parent 1bb3dcf commit 8727bc3
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ def _apply_response_attributes(span: Span, result):

retry_attempts = metadata.get("RetryAttempts")
if retry_attempts is not None:
# TODO: update when semantic conventinos exists
# TODO: update when semantic conventions exists
span.set_attribute("retry_attempts", retry_attempts)

status_code = metadata.get("HTTPStatusCode")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
This env var must be set to ``true`` in order to enable trace context injection into logs by calling ``logging.basicConfig()`` and
setting a logging format that makes use of the injected tracing variables.
Alternatively, ``set_logging_format`` argument can be set to ``True`` when initializing the ``LoggingInstrumentor`` class to acheive the
Alternatively, ``set_logging_format`` argument can be set to ``True`` when initializing the ``LoggingInstrumentor`` class to achieve the
same effect.
.. code-block::
Expand All @@ -65,7 +65,7 @@
This env var can be used to instruct the instrumentation to use a custom logging format.
Alternatively, a custom logging format can be passed to the ``LoggingInsrumentor`` as the ``logging_format`` argument. For example:
Alternatively, a custom logging format can be passed to the ``LoggingInstrumentor`` as the ``logging_format`` argument. For example:
.. code-block::
Expand Down Expand Up @@ -108,7 +108,7 @@
If you code or some other library/framework you are using calls logging.basicConfig before this integration is enabled, then this integration's logging
format will not be used and log statements will not contain tracing context. For this reason, you'll need to make sure this integration is enabled as early
as possible in the service lifecycle or your framework is configured to use a logging format with placeholders for tracing context. This can be acheived by
as possible in the service lifecycle or your framework is configured to use a logging format with placeholders for tracing context. This can be achieved by
adding the following placeholders to your logging format:
.. code-block::
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ def _instrument(self, **kwargs):
``name_callback``: Callback which calculates a generic span name for an
outgoing HTTP request based on the method and url.
Optional: Defaults to get_default_span_name.
``excluded_urls``: A string containing a comma-delimitted
``excluded_urls``: A string containing a comma-delimited
list of regexes used to exclude URLs from tracking
"""
tracer_provider = kwargs.get("tracer_provider")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def home(request):
Request/Response hooks
**********************
Utilize request/reponse hooks to execute custom logic to be performed before/after performing a request. The server request hook takes in a server span and ASGI
Utilize request/response hooks to execute custom logic to be performed before/after performing a request. The server request hook takes in a server span and ASGI
scope object for every incoming request. The client request hook is called with the internal span and an ASGI scope which is sent as a dictionary for when the method recieve is called.
The client response hook is called with the internal span and an ASGI event which is sent as a dictionary for when the method send is called.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ def _instrument(self, **kwargs):
In order to work around this, we patch the __init__ method of RequestHandler and then dynamically patch
the prepare, on_finish and log_exception methods of the derived classes _only_ the first time we see them.
Note that the patch does not apply on every single __init__ call, only the first one for the enture
Note that the patch does not apply on every single __init__ call, only the first one for the entire
process lifetime.
"""
tracer_provider = kwargs.get("tracer_provider")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def test_uninstrument(self):
# instrument again to avoid warning message on tearDown
URLLib3Instrumentor().instrument()

def test_suppress_instrumntation(self):
def test_suppress_instrumentation(self):
suppression_keys = (
_SUPPRESS_HTTP_INSTRUMENTATION_KEY,
_SUPPRESS_INSTRUMENTATION_KEY,
Expand Down
2 changes: 1 addition & 1 deletion scripts/build_a_package.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ pkg_version=${pkg_name_and_version#opentelemetry-*==}
# Get the latest versions of packaging tools
python3 -m pip install --upgrade pip setuptools wheel packaging

# Validate vesrion against PEP 440 conventions: https://packaging.pypa.io/en/latest/version.html
# Validate version against PEP 440 conventions: https://packaging.pypa.io/en/latest/version.html
python3 -c "from packaging.version import Version; Version('${pkg_version}')"

basedir=$(git rev-parse --show-toplevel)
Expand Down

0 comments on commit 8727bc3

Please sign in to comment.