Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ The full list of changes can be found in the compare view for the respective rel

### Changed

- profiles: clarify Sample message usage guidance docs. [#742](https://github.com/open-telemetry/opentelemetry-proto/pull/742)
- profiles: improve Sample message clarity and usage documentation. [#724](https://github.com/open-telemetry/opentelemetry-proto/pull/724)

### Fixed

- logs: `SEVERITY_NUMBER_UNSPECIFIED` can be used as the `severity_number` field is optional. [#736](https://github.com/open-telemetry/opentelemetry-proto/pull/736)
Expand Down
6 changes: 5 additions & 1 deletion opentelemetry/proto/profiles/v1development/profiles.proto
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ message ValueType {
// as having a shared identity and an associated collection of per-observation data points.
// Samples having the same identity SHOULD be combined by inserting timestamps and values to the data arrays.
//
// Examples of different ways of representing a sample with the total value of 10:
// Examples of different ways ('shapes') of representing a sample with the total value of 10:
//
// Report of a stacktrace at 10 timestamps (consumers must assume the value is 1 for each point):
// values: []
Expand All @@ -381,6 +381,10 @@ message ValueType {
// Report of a stacktrace at 4 timestamps where each point records a specific value:
// values: [2, 2, 3, 3]
// timestamps_unix_nano: [1, 2, 3, 4]
//
// All Samples for a Profile SHOULD have the same shape, i.e. all data observation series should consistently
// adopt the same data recording style.
//
message Sample {

// A Sample's identity (i.e. 'primary key') is the tuple of {stack_index, set_of(attribute_indices), link_index}
Expand Down