profiles: improve Sample message clarity and usage documentation.#724
Merged
Conversation
Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
Contributor
Author
|
@open-telemetry/profiling-maintainers as discussed in the SIG meeting, this replaces #714, retaining the straightforward/agreed bits but removing/deferring the aggregation doc changes until further discussion. |
aalexand
approved these changes
Oct 8, 2025
felixge
reviewed
Oct 16, 2025
Member
|
We also discussed in one of the SIG meetings that we should document that the "shape" of the samples in terms of values vs timestamps should be the same for all samples in the given profile. For example, we disallow having one sample with timestamps and another a timestamp-less aggregated value sample. Do we want to add that note here or in a separate PR? |
florianl
approved these changes
Oct 17, 2025
Member
|
Can you please an entry in |
christos68k
approved these changes
Oct 29, 2025
jsuereth
requested changes
Oct 29, 2025
Contributor
jsuereth
left a comment
jsuereth
left a comment
There was a problem hiding this comment.
As discussed offline, I don't think we should move this direction.
- This does not allow sharing of resource/transformation code in the collector because we just move the data from resource elsewhere, so no sharing
- We should figure out efficiency issues for profiling separately.
Member
|
@open-telemetry/proto-approvers Please approve and merge. |
Member
|
@jsuereth you blocked this earlier. What's your current position on this? |
felixge
approved these changes
Nov 14, 2025
jsuereth
reviewed
Nov 19, 2025
jsuereth
approved these changes
Nov 20, 2025
Contributor
jsuereth
left a comment
jsuereth
left a comment
There was a problem hiding this comment.
Thanks for updating this folks! Approving
fandreuz
added a commit
to fandreuz/async-profiler
that referenced
this pull request
Dec 17, 2025
fandreuz
added a commit
to fandreuz/async-profiler
that referenced
this pull request
Dec 17, 2025
fandreuz
added a commit
to fandreuz/async-profiler
that referenced
this pull request
Dec 17, 2025
fandreuz
added a commit
to fandreuz/async-profiler
that referenced
this pull request
Dec 17, 2025
fandreuz
added a commit
to fandreuz/async-profiler
that referenced
this pull request
Dec 17, 2025
florianl
added a commit
to florianl/opentelemetry-collector
that referenced
this pull request
Feb 27, 2026
open-telemetry/opentelemetry-proto#724 introduces a breaking change to the Profiles signal. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl
added a commit
to florianl/opentelemetry-collector
that referenced
this pull request
Feb 27, 2026
open-telemetry/opentelemetry-proto#724 introduces a breaking change to the Profiles signal. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
github-merge-queue Bot
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Mar 10, 2026
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description open-telemetry/opentelemetry-proto#724 introduces a breaking change to the Profiles signal. This is a follow up to #14739. <!-- Issue number if applicable --> #### Link to tracking issue Fixes # <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl
added a commit
to elastic/devfiler
that referenced
this pull request
Mar 13, 2026
As #77 introduces breaking changes (open-telemetry/opentelemetry-proto#724), bump the version of devfiler. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.