Exclude buf.yaml from release archives via .gitattributes (#604)#721
Exclude buf.yaml from release archives via .gitattributes (#604)#721RajaVarmaGVSSR wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
|
|
|
Please consider adding |
|
@tigrannajaryan, sorry I am new to this. Are there specific reviewers or groups I need to ask for reviews ? |
|
@open-telemetry/specs-sponsors @open-telemetry/technical-committee please review. |
There was a problem hiding this comment.
Is there actually a need to remove this file? Does it create any problems?
It's part of the validation and code-generation and we ship proto files as they are in the archive. We expect consumers of the release to generate code. In a generic case, without this file, consumers might not be able to generate code from the proto we provide.
|
I think I agree with you on the necessity bit, and that there is no need to take the risk of breaking a downstream workflow dependent on the buf for generating code given that there is no value add in terms of functionality. |
Adds an export-ignore rule for buf.yaml to prevent it from appearing in GitHub release
tarballs and zip files.
Background:
buf.yaml to appear in the tarball.
Closes #604