Skip to content

Document more explicitly the dictionary zero element requirement. #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tigrannajaryan merged 3 commits into from
Sep 13, 2025
+14 −1
Merged

Document more explicitly the dictionary zero element requirement. #711

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36bd74d
Document more explicitly the dictionary zero element requirement.
aalexand Sep 4, 2025
68e841a
Merge branch 'main' into doczeros
aalexand Sep 9, 2025
8f27fe9
Merge branch 'main' into doczeros
aalexand Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion opentelemetry/proto/profiles/v1development/profiles.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,19 +106,28 @@ option go_package = "go.opentelemetry.io/proto/otlp/profiles/v1development";
message ProfilesDictionary {
// Mappings from address ranges to the image/binary/library mapped
// into that address range referenced by locations via Location.mapping_index.
//
// mapping_table[0] must always be zero value (Mapping{}) and present.
Comment thread
pellared marked this conversation as resolved.
repeated Mapping mapping_table = 1;

// Locations referenced by samples via Stack.location_indices.
//
// location_table[0] must always be zero value (Location{}) and present.
repeated Location location_table = 2;

// Functions referenced by locations via Line.function_index.
//
// function_table[0] must always be zero value (Function{}) and present.
repeated Function function_table = 3;

// Links referenced by samples via Sample.link_index.
//
// link_table[0] must always be zero value (Link{}) and present.
repeated Link link_table = 4;

// A common table for strings referenced by various messages.
// string_table[0] must always be "".
//
// string_table[0] must always be "" and present.
repeated string string_table = 5;

// A common table for attributes referenced by various messages.
Expand All @@ -139,9 +148,13 @@ message ProfilesDictionary {
// These restrictions can change in a minor release.
// The restrictions take origin from the OpenTelemetry specification:
// https://github.com/open-telemetry/opentelemetry-specification/blob/v1.47.0/specification/common/README.md#attribute.
//
// attribute_table[0] must always be zero value (KeyValueAndUnit{}) and present.
repeated KeyValueAndUnit attribute_table = 6;

// Stacks referenced by samples via Sample.stack_index.
//
// stack_table[0] must always be zero value (Stack{}) and present.
repeated Stack stack_table = 7;
}

Expand Down