Skip to content

Unsigned Profile time_nanos and duration_nanos #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tigrannajaryan merged 3 commits into from
Aug 14, 2025
Merged

Unsigned Profile time_nanos and duration_nanos #692

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0017787
Unsigned Profile time_nanos and duration_nanos
christos68k Aug 7, 2025
f947553
Switch to fixed64 for unix_nano
christos68k Aug 7, 2025
6b6979a
Merge branch 'main' into ck/timestamps
tigrannajaryan Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions opentelemetry/proto/profiles/v1development/profiles.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,9 @@ message Profile {
// interpretation of results.

// Time of collection (UTC) represented as nanoseconds past the epoch.
int64 time_nanos = 4;
fixed64 time_unix_nano = 4;
// Duration of the profile, if a duration makes sense.
int64 duration_nanos = 5;
uint64 duration_nano = 5;
// The kind of events between sampled occurrences.
// e.g [ "cpu","cycles" ] or [ "heap","bytes" ]
ValueType period_type = 6;
Expand Down Expand Up @@ -431,7 +431,7 @@ message Sample {

// Timestamps associated with Sample represented in nanoseconds. These
// timestamps should fall within the Profile's time range.
repeated uint64 timestamps_unix_nano = 6;
repeated fixed64 timestamps_unix_nano = 6;
Comment thread
tigrannajaryan marked this conversation as resolved.
}

// Describes the mapping of a binary in memory, including its address range,
Expand Down