Skip to content

profiles: make profile_id optional #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tigrannajaryan merged 3 commits into from
Jun 27, 2025
Merged

profiles: make profile_id optional #665

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c81b8d8
profile_id optional
fandreuz May 29, 2025
56c68c3
Merge branch 'main' into profile-id-optional
tigrannajaryan Jun 13, 2025
bf132af
Merge branch 'main' into profile-id-optional
fandreuz Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions opentelemetry/proto/profiles/v1development/profiles.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,11 @@ message Profile {
int32 default_sample_type_index = 9;

// A globally unique identifier for a profile. The ID is a 16-byte array. An ID with
// all zeroes is considered invalid.
//
// This field is required.
// all zeroes is considered invalid. It may be used for deduplication and signal
Comment thread
fandreuz marked this conversation as resolved.
// correlation purposes. It is acceptable to treat two profiles with different values
// in this field as not equal, even if they represented the same object at an earlier
// time.
// This field is optional; an ID may be assigned to an ID-less profile in a later step.
Comment thread
fandreuz marked this conversation as resolved.
bytes profile_id = 10;

// dropped_attributes_count is the number of attributes that were discarded. Attributes
Expand Down