Skip to content

Switch the otlp profiles root element to be ProfilesData #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmathieu wants to merge 1 commit into from
Closed

Switch the otlp profiles root element to be ProfilesData #648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions opentelemetry/proto/collector/profiles/v1development/profiles_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,13 @@ service ProfilesService {
}

message ExportProfilesServiceRequest {
// An array of ResourceProfiles.
// For data coming from a single resource this array will typically contain one
// element. Intermediary nodes (such as OpenTelemetry Collector) that receive
// data from multiple origins typically batch the data before forwarding further and
// in that case this array will contain multiple elements.
repeated opentelemetry.proto.profiles.v1development.ResourceProfiles resource_profiles = 1;
// The ProfilesData.
// For data coming from a single resource this object will typically contain
// one element resource profiles. Intermediary nodes (such as OpenTelemetry
// Collector) that receive data from multiple origins typically batch the
// data before forwarding further and in that case there will be multiple
// resources.
Comment on lines +34 to +39
Copy link
Copy Markdown
Member

@christos68k christos68k Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some of text from the proto here (in light of recent changes):

Suggested change
// The ProfilesData.
// For data coming from a single resource this object will typically contain
// one element resource profiles. Intermediary nodes (such as OpenTelemetry
// Collector) that receive data from multiple origins typically batch the
// data before forwarding further and in that case there will be multiple
// resources.
// The ProfilesData which contains an array of ResourceProfiles.
// For data coming from an SDK profiler, this array will typically contain one
// element. Host-level profilers will usually create one ResourceProfile per
// container, as well as one additional ResourceProfile grouping all samples
// from non-containerized processes. Intermediary nodes (such as OpenTelemetry
// Collector) that receive data from multiple origins typically batch the
// data before forwarding further and in that case there will also be multiple
// ResourceProfiles.

opentelemetry.proto.profiles.v1development.ProfilesData profiles_data = 1;
}

message ExportProfilesServiceResponse {
Expand Down