profiles: Move lookup tables to ProfilesData#644
Merged
tigrannajaryan merged 2 commits intoopen-telemetry:mainfrom Apr 24, 2025
Merged
profiles: Move lookup tables to ProfilesData#644tigrannajaryan merged 2 commits intoopen-telemetry:mainfrom
tigrannajaryan merged 2 commits intoopen-telemetry:mainfrom
Conversation
Implements open-telemetry#628 (comment). Signed-off-by: Florian Lehner <florian.lehner@elastic.co> Co-authored-by: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com> Co-authored-by: Nayef Ghattas <11560964+Gandem@users.noreply.github.com>
rockdaboot
reviewed
Apr 16, 2025
rockdaboot
reviewed
Apr 16, 2025
felixge
approved these changes
Apr 17, 2025
Member
felixge
left a comment
felixge
left a comment
There was a problem hiding this comment.
Thanks, this is a great step forward 🙇 ! LGTM overall.
Member
|
I like this approach — it gets us everything we want, with the only downside being more complexity in merging Profiles. Since it's a one-time, internal change in the collector, I think it's worth it. |
petethepig
approved these changes
Apr 17, 2025
christos68k
reviewed
Apr 22, 2025
Member
christos68k
left a comment
christos68k
left a comment
There was a problem hiding this comment.
Added some suggestions for clarity and consistency
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
rockdaboot
approved these changes
Apr 23, 2025
dmathieu
approved these changes
Apr 23, 2025
pellared
approved these changes
Apr 23, 2025
Kielek
approved these changes
Apr 23, 2025
christos68k
approved these changes
Apr 23, 2025
aalexand
approved these changes
Apr 23, 2025
Member
|
I will merge this tomorrow. We normally merge 2 days after the last change. |
jhalliday
approved these changes
Apr 24, 2025
This was referenced Apr 30, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #628 (comment).