Remove comment on each service about keeping the RPC alive#637
Merged
jsuereth merged 2 commits intoopen-telemetry:mainfrom Mar 28, 2025
Merged
Remove comment on each service about keeping the RPC alive#637jsuereth merged 2 commits intoopen-telemetry:mainfrom
jsuereth merged 2 commits intoopen-telemetry:mainfrom
Conversation
Tigran explained this comment was likely a hold over from the OpenCensus protobufs which did use streaming RPC's. Unary RPC's, which are used by the OpenTelemetry protocol, can not be kept alive making the comment out of place.
tigrannajaryan
approved these changes
Mar 25, 2025
christos68k
approved these changes
Mar 25, 2025
jack-berg
approved these changes
Mar 25, 2025
tigrannajaryan
changed the title
jsuereth
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tigran explained this comment was likely a hold over from the OpenCensus protobufs which did use streaming RPC's. Unary RPC's, which are used by the OpenTelemetry protocol, can not be kept alive making the comment out of place.