Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otlp-spec): Clarified "reject" meaning of the HTTP PartialSuccess explanation. #539

Closed
wants to merge 2 commits into from
Closed

fix(otlp-spec): Clarified "reject" meaning of the HTTP PartialSuccess explanation. #539

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebcc6df
fix(otlp-spec): Clarified "reject" meaning of the PartialSuccess expl…
bwplotka Mar 27, 2024
1bae6be
Update specification.md
bwplotka Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions docs/specification.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,9 +498,15 @@ in case of a successful response.

##### Partial Success

If the request is only partially accepted
(i.e. when the server accepts only parts of the data and rejects the rest), the
server MUST respond with `HTTP 200 OK`. The response body MUST be the same
The partial success is when the request is only partially accepted (i.e. when the
server accepts only parts of the data and fails the rest). In such a case:

- If all of the samples are rejected (not-retryable failures), the server MUST
respond with `HTTP 200 OK`.
- If any of the failed sample write attempts are retry-able, the server MUST
respond with related retry-able status code mentioned below.

In all cases the response body MUST be the same
[Export\<signal>ServiceResponse](../opentelemetry/proto/collector)
message as in the [Full Success](#full-success-1) case.

Expand Down Expand Up @@ -553,7 +559,7 @@ The requests that receive a response status code listed in following table SHOUL
be retried.
All other `4xx` or `5xx` response status codes MUST NOT be retried.

|HTTP response status code|
|Retryable HTTP response status code|
|---------|
|429 Too Many Requests|
|502 Bad Gateway|
Expand Down
Loading