Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: convert Tracestate to an unstructured raw string field in Span #55

Closed
tigrannajaryan opened this issue Nov 14, 2019 · 2 comments · Fixed by #57
Closed

Proposal: convert Tracestate to an unstructured raw string field in Span #55

tigrannajaryan opened this issue Nov 14, 2019 · 2 comments · Fixed by #57

Comments

@tigrannajaryan
Copy link
Member

The Span.tracestate field is currently a structured data that stores fully decoded Tracestate. However, there does not seem to be a good use case for keeping this in structured form, there are no known applications that work with this elements of this data, other than just passing it around fully.

I suggest to eliminate Tracestate message type and make Span.tracestate a simple string field in w3c-trace-context format.

This has been previously discussed as part of open-telemetry/oteps#59 (comment) and decided to be addressed in a separate PR.
@tigrannajaryan
Copy link
Member Author

@yurishkuro @bogdandrutu I need your opinion on this, please.

@yurishkuro
Copy link
Member

+1. It means less work for the tracer to package this data.

tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-proto that referenced this issue Nov 15, 2019
Convert tracestate to an unstructured raw string field
8e23a80 
The Span.tracestate field was a structured data that stores fully decoded Tracestate.
However, there is no good use case for keeping this in structured form, there are no
known applications that work with this elements of this data, other than just passing
it around fully.

This change eliminates Tracestate message type and makse Span.tracestate a simple string
field in w3c-trace-context format.

Resolves open-telemetry#55
@tigrannajaryan tigrannajaryan mentioned this issue Nov 15, 2019
Merged
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-proto that referenced this issue Nov 15, 2019
Convert tracestate to an unstructured raw string field
9f69db3 
The Span.tracestate field was a structured data that stores fully decoded Tracestate.
However, there is no good use case for keeping this in structured form, there are no
known applications that work with this elements of this data, other than just passing
it around fully.

This change eliminates Tracestate message type and makse Span.tracestate a simple string
field in w3c-trace-context format.

Resolves open-telemetry#55
SergeyKanzhelev pushed a commit that referenced this issue Nov 19, 2019
@tigrannajaryan @SergeyKanzhelev
Convert tracestate to an unstructured raw string field (#57)
64858ef 
The Span.tracestate field was a structured data that stores fully decoded Tracestate.
However, there is no good use case for keeping this in structured form, there are no
known applications that work with this elements of this data, other than just passing
it around fully.

This change eliminates Tracestate message type and makse Span.tracestate a simple string
field in w3c-trace-context format.

Resolves #55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert tracestate to an unstructured raw string field tigrannajaryan/opentelemetry-proto
2 participants
@yurishkuro @tigrannajaryan