Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated rector rule #1352

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Jul 19, 2024

this silences a rector warning which was breaking local build

this silences a rector warning which was breaking local build
@brettmc brettmc requested a review from a team July 19, 2024 01:45
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.59%. Comparing base (17ad56a) to head (1b672a8).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1352      +/-   ##
============================================
- Coverage     74.61%   74.59%   -0.02%     
  Complexity     2504     2504              
============================================
  Files           355      355              
  Lines          7180     7180              
============================================
- Hits           5357     5356       -1     
- Misses         1823     1824       +1     
Flag Coverage Δ
8.1 74.26% <ø> (-0.06%) ⬇️
8.2 74.49% <ø> (-0.02%) ⬇️
8.3 74.56% <ø> (+0.04%) ⬆️
8.4 74.48% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17ad56a...1b672a8. Read the comment docs.

@bobstrecansky bobstrecansky merged commit e4f9604 into open-telemetry:main Jul 19, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants