Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event logger spec compliance #1335

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Jun 14, 2024

update event logger to conform to spec 1.34.0, specifically:

  • implement ForceFlush, which delegates to the LoggerProvider
  • rename payload to body

Fixes: #1328
Fixes: #1327

update event logger to conform to spec 1.34.0, specifically:
- implement ForceFlush, which delegates to the LoggerProvider
@brettmc brettmc requested a review from a team June 14, 2024 11:38
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.43%. Comparing base (eebf23a) to head (011e901).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1335      +/-   ##
============================================
+ Coverage     74.29%   74.43%   +0.13%     
- Complexity     2491     2494       +3     
============================================
  Files           353      354       +1     
  Lines          7135     7142       +7     
============================================
+ Hits           5301     5316      +15     
+ Misses         1834     1826       -8     
Flag Coverage Δ
8.1 73.99% <90.00%> (-0.05%) ⬇️
8.2 74.33% <90.00%> (+0.16%) ⬆️
8.3 74.18% <90.00%> (-0.08%) ⬇️
8.4 74.25% <90.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/SDK/Logs/EventLogger.php 100.00% <100.00%> (ø)
src/SDK/Logs/EventLoggerProvider.php 100.00% <100.00%> (ø)
src/SDK/Logs/EventLoggerProviderFactory.php 100.00% <100.00%> (ø)
src/SDK/Logs/NoopEventLoggerProvider.php 100.00% <100.00%> (ø)
src/API/Logs/NoopEventLogger.php 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eebf23a...011e901. Read the comment docs.

@brettmc brettmc merged commit a90f18c into open-telemetry:main Jun 26, 2024
10 checks passed
@brettmc brettmc deleted the eventloggerprovider-1.34.0 branch June 26, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants