update semconv to 1.26.0 #1316
update semconv to 1.26.0 #1316
Conversation
note that messaging.client_id was renamed to messaging.client.id, which causes a conflict in const name. It hasn't been resolved upstream yet, but manually removing the duplicate seems like the best way to go for us.
| @@ -17,3 +17,13 @@ | |||
| * @deprecated Use CONTAINER_IMAGE_TAGS | |||
| */ | |||
| public const CONTAINER_IMAGE_TAG = 'container.image.tag'; | |||
|
|
|||
There was a problem hiding this comment.
these two were removed from semconv upstream
| @@ -3,31 +3,11 @@ | |||
| */ | |||
| public const FAAS_EXECUTION = 'faas.execution'; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
all these guys were re-added to semconv as deprecated, so no longer needed here.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1316 +/- ##
============================================
- Coverage 74.28% 74.23% -0.05%
Complexity 2491 2491
============================================
Files 353 353
Lines 7135 7135
============================================
- Hits 5300 5297 -3
- Misses 1835 1838 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Converting back to draft, awaiting agreement in open-telemetry/semantic-conventions#1031 on how to handle |
The recommendation from semconv maintainers is to clobber the old, which is what this PR does. |
note that messaging.client_id was renamed to messaging.client.id, which causes a conflict in const name. It hasn't been resolved upstream yet, but manually removing the duplicate seems like the best way to go for us.