Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated link to 3musketeers site. #1315

Merged

Conversation

ChrisLightfootWild
Copy link
Contributor

@ChrisLightfootWild ChrisLightfootWild commented May 21, 2024

I think the original site might have expired 👀

Updated per https://github.com/flemay/3musketeers:

image

@ChrisLightfootWild ChrisLightfootWild requested a review from a team May 21, 2024 14:20
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.39%. Comparing base (eaba9e3) to head (b59a993).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1315      +/-   ##
============================================
+ Coverage     74.28%   74.39%   +0.11%     
  Complexity     2491     2491              
============================================
  Files           353      353              
  Lines          7135     7135              
============================================
+ Hits           5300     5308       +8     
+ Misses         1835     1827       -8     
Flag Coverage Δ
8.1 74.00% <ø> (ø)
8.2 74.16% <ø> (-0.06%) ⬇️
8.3 74.26% <ø> (+0.09%) ⬆️
8.4 74.26% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaba9e3...b59a993. Read the comment docs.

@bobstrecansky
Copy link
Collaborator

bobstrecansky commented May 21, 2024

https://3musketeers.pages.dev/ didn't load for me either? Might be a corp firewall problem, loaded fine for me on mobile.

@ChrisLightfootWild
Copy link
Contributor Author

https://3musketeers.pages.dev/ didn't load for me either? Might be a corp firewall problem, loaded fine for me on mobile.

Strange - it's a Cloudflare Pages site by the looks of it, so nothing too suspicious! Thanks for checking @bobstrecansky 👍

@brettmc
Copy link
Collaborator

brettmc commented May 21, 2024

Works for me.

@brettmc brettmc merged commit 39f81a3 into open-telemetry:main May 21, 2024
10 checks passed
@ChrisLightfootWild ChrisLightfootWild deleted the fix/development-doc-link branch May 22, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants