-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds experimental service.instance.id resource detector #1309
Adds experimental service.instance.id resource detector #1309
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1309 +/- ##
============================================
- Coverage 74.32% 74.23% -0.10%
- Complexity 2491 2493 +2
============================================
Files 353 354 +1
Lines 7135 7144 +9
============================================
Hits 5303 5303
- Misses 1832 1841 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@matt-hensley looking good. phan and deptrac issues are config-related:
|
Couple of minor nits from me, but otherwise looks good. |
Co-authored-by: Brett McBride <[email protected]>
The failure is because we just moved from |
@matt-hensley you can ignore the psalm errors. I'm aware of them: mockery/mockery#1421 |
@matt-hensley if you merge in main now, those psalm errors should be gone. |
Adds experimental service.instance.id resource detector per experimental semantic conventions.
This detector has been added to the list of well known detectors with the ID
service
and can be enabled via theOTEL_PHP_DETECTORS
environment variable.