adding PushMetricExporterInterface #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open-telemetry/opentelemetry-specification#3563 clarifies the behaviour of forceFlush with push/non-push metric exporters. Break forceFlush out into a PushMetricExporterInterface, and update ExportingReader to only collect/flush if exporter is a push metric exporter.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1097 +/- ##
============================================
+ Coverage 83.06% 83.12% +0.05%
+ Complexity 2203 2202 -1
============================================
Files 282 282
Lines 6277 6275 -2
============================================
+ Hits 5214 5216 +2
+ Misses 1063 1059 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
bobstrecansky
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open-telemetry/opentelemetry-specification#3563 clarifies the behaviour of forceFlush with push/non-push metric exporters.
Break forceFlush out into a PushMetricExporterInterface, and update ExportingReader to only collect/flush if exporter is a push metric exporter.
Fixes #1086