Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Jaeger Propagator #1187

Closed
weslenteche opened this issue Dec 10, 2023 · 2 comments · Fixed by #1188
Closed

Support for Jaeger Propagator #1187

weslenteche opened this issue Dec 10, 2023 · 2 comments · Fixed by #1188
Assignees
@weslenteche

Comments

@weslenteche
Copy link
Contributor

The OpenTelemetry specification suggests that a propagator for Jaeger MUST be implemented.

Is your feature request related to a problem?

Some applications, typically third party, rely on "older" implementations of Opentracing using the Jaeger tracing context and this information is not being linked to the current PHP library.

Describe the solution you'd like

Adding a propagator that implements, understands and propagate the Jaeger (uber header) format.

Additional context
If it really hasn't been implemented, I'd love to contribute a PR
@brettmc
Copy link
Collaborator

brettmc commented Dec 10, 2023

I don't remember us ever having a jaeger propagator. We removed the jaeger exporter in #890 when the client libraries were abandoned, but that doesn't mean the propagator can't be implemented. It can go in the Extension dir alongside B3 and CloudTrace if you'd like to have a go at implementing.

@weslenteche
Copy link
Contributor Author

Thanks for the answer, I'll start working on it

@weslenteche weslenteche mentioned this issue Dec 11, 2023
Merged
@weslenteche weslenteche mentioned this issue Apr 10, 2024
Merged
5 tasks
yurishkuro pushed a commit to open-telemetry/opentelemetry-specification that referenced this issue Apr 11, 2024
@weslenteche @carlosalberto
Mark jaeger propagator as implemented for PHP (#3993)
700f513 
## Changes

Included in
open-telemetry/opentelemetry-php#1187

For non-trivial changes, follow the [change proposal
process](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CONTRIBUTING.md#proposing-a-change).

* [ ] Related issues #
* [ ] Related [OTEP(s)](https://github.com/open-telemetry/oteps) #
* [ ] Links to the prototypes (when adding or changing features)
* [ ]
[`CHANGELOG.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md)
file updated for non-trivial changes
* [x]
[`spec-compliance-matrix.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix.md)
updated if necessary

Co-authored-by: Carlos Alberto Cortez <[email protected]>
carlosalberto added a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
@weslenteche @carlosalberto
Mark jaeger propagator as implemented for PHP (open-telemetry#3993)
cb25db8 
## Changes

Included in
open-telemetry/opentelemetry-php#1187

For non-trivial changes, follow the [change proposal
process](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CONTRIBUTING.md#proposing-a-change).

* [ ] Related issues #
* [ ] Related [OTEP(s)](https://github.com/open-telemetry/oteps) #
* [ ] Links to the prototypes (when adding or changing features)
* [ ]
[`CHANGELOG.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md)
file updated for non-trivial changes
* [x]
[`spec-compliance-matrix.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix.md)
updated if necessary

Co-authored-by: Carlos Alberto Cortez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weslenteche weslenteche

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Jaeger Propagator weslenteche/opentelemetry-php
2 participants
@brettmc @weslenteche