note a todo on reconfiguring meters

open-telemetry · Jul 25, 2024 · e7e0104 · e7e0104
1 parent 6fb6b1d
commit e7e0104
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/SDK/Metrics/MeterProvider.php b/src/SDK/Metrics/MeterProvider.php
@@ -131,8 +131,9 @@ public static function builder(): MeterProviderBuilder
     }
 
     /**
-     * Update the {@link Configurator} for a {@link MeterProvider}, which will
-     * reconfigure all meters created from the provider.
+     * Update the {@link Configurator} for a {@link MeterProvider}, which will reconfigure
+     *  all meters created from the provider.
+     * @todo enabling a previous-disabled meter does not drop/recreate the underlying metric streams, so previously collected synchronous metrics will still be exported.
      * @experimental
      */
     public function updateConfigurator(ScopeConfigurator $configurator): void

diff --git a/tests/Integration/SDK/Metrics/MeterConfigTest.php b/tests/Integration/SDK/Metrics/MeterConfigTest.php
@@ -104,7 +104,7 @@ public function test_metrics_not_exported_when_disabled(): void
      */
     public function test_streams_recreated_on_enable(): void
     {
-        $this->markTestSkipped('TODO implement drop/create streams'); /* @phpstan-ignore-next-line */
+        $this->markTestSkipped('TODO implement drop/create streams'); // @phpstan-ignore-next-line
         $clock = new TestClock(self::T0);
         $disabledConfigurator = Configurator::builder()
             ->addCondition(new Name('*'), State::DISABLED)