Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: most tests are failing (crashing) due to lack of refcount increase #7

Merged

Conversation

pdelewski
Copy link
Member

@pdelewski pdelewski commented Oct 11, 2022

Testing it on PHP-8.2. In debug mode it results in following assertion Assertion failed: (zval_gc_type((ref)->gc.u.type_info) == 7 || zval_gc_type((ref)->gc.u.type_info) == 8), function gc_possible_root, file zend_gc.c, line 647

PASS Check if otel_instrumentation is loaded [tests/001.phpt]
PASS Check if hook returns true [tests/002.phpt]
FAIL Check if hooks are invoked [tests/003.phpt]
FAIL Check if multiple hooks are invoked [tests/004.phpt]
FAIL Check if hooks receives function information [tests/005.phpt]
FAIL Check if hooks receives arguments and return value [tests/006.phpt]
FAIL Check if hook receives exception [tests/007.phpt]
FAIL Check if hook can modify arguments [tests/008.phpt]
FAIL Check if hook can modify not provided arguments [tests/009.phpt]
FAIL Check if hook can modify return value [tests/010.phpt]
FAIL Check if hooks are invoked for closures [tests/function_closure.phpt]
FAIL Check if hooks are invoked for first class callables [tests/function_first_class_callable.phpt]
`

@pdelewski pdelewski changed the title fix: most test are failing (crashing) due to lack of refcount increase fix: most tests are failing (crashing) due to lack of refcount increase Oct 11, 2022
@pdelewski pdelewski force-pushed the fix_lack_of_refcount_increase branch from 3a98ae6 to 304ba1e Compare October 11, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants