Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic symfony instrumentation bundle with kernel request listener #77

Merged
merged 8 commits into from
Aug 28, 2022

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Aug 13, 2022

No description provided.

@welcome
Copy link

welcome bot commented Aug 13, 2022

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@codecov
Copy link

codecov bot commented Aug 13, 2022

Codecov Report

Merging #77 (572d592) into main (7b5c466) will decrease coverage by 3.62%.
The diff coverage is 83.91%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #77      +/-   ##
============================================
- Coverage     95.81%   92.18%   -3.63%     
- Complexity      182      237      +55     
============================================
  Files            18       26       +8     
  Lines           454      653     +199     
============================================
+ Hits            435      602     +167     
- Misses           19       51      +32     
Flag Coverage Δ
7.4 92.18% <83.91%> (-3.63%) ⬇️
8.0 92.18% <83.91%> (-3.63%) ⬇️
8.1 92.18% <83.91%> (-3.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Symfony/OtelBundle/Resources/services.php 0.00% <0.00%> (ø)
...c/Symfony/OtelBundle/Resources/services_kernel.php 0.00% <0.00%> (ø)
src/Symfony/OtelBundle/OtelBundle.php 16.66% <16.66%> (ø)
.../Symfony/OtelBundle/HttpKernel/RequestListener.php 89.32% <89.32%> (ø)
...tion/Compiler/SetAliasIfNotDefinedCompilerPass.php 100.00% <100.00%> (ø)
...y/OtelBundle/DependencyInjection/Configuration.php 100.00% <100.00%> (ø)
...y/OtelBundle/DependencyInjection/OtelExtension.php 100.00% <100.00%> (ø)
...ymfony/OtelBundle/HttpKernel/HeadersPropagator.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5c466...572d592. Read the comment docs.

@brettmc
Copy link
Collaborator

brettmc commented Aug 15, 2022

@Nevay - happy to merge this when you say it's ready

@Nevay
Copy link
Contributor Author

Nevay commented Aug 22, 2022

Should be ready, but I'm fine with waiting until 0.0.15 to resolve the broken/skipped test.

@brettmc
Copy link
Collaborator

brettmc commented Aug 25, 2022

@Nevay I've tagged 0.0.15

@brettmc brettmc merged commit c822915 into open-telemetry:main Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants