Move validation to be part of the CRD #3321
Conversation
|
@swiatekm Based on my changes, I just wanted to know if am on the right track before I proceed for all CRDs. Thanks. |
There was a problem hiding this comment.
You're making changes in the right place, but I'm not sure they're the right changes for the effect you want.
Try running make bundle and examining the result of your changes to the generated CRDS. This should give you a better sense of whether you're on the right path.
| @@ -90,10 +90,10 @@ type OpenTelemetryCollectorSpec struct { | |||
| // +optional | |||
| TargetAllocator TargetAllocatorEmbedded `json:"targetAllocator,omitempty"` | |||
| // Mode represents how the collector should be deployed (deployment, daemonset, statefulset or sidecar) | |||
| // +optional | |||
| // +kubebuilder:validation:Enum=ModeDeployment;ModeDaemonSet;ModeStatefulSet;ModeSidecar | |||
There was a problem hiding this comment.
This specific change is superfluous. If you look at the generated CRD, this validation is already there. If we look at what's missing compared to the webhook, we should add a marker here to set the default to deployment.
Keep in mind that the markers deal with raw values of the field as they appear in the resource in K8s, not the aliases we have for them in Go code. So you should use deployment instead of ModeDeployment.
|
@swiatekm I addressed your comment and added more validation rules. I'll appreciate your review. Thank you. |
| @@ -110,6 +113,7 @@ type OpenTelemetryCollectorSpec struct { | |||
| // functionality is only available if one of the valid modes is set. | |||
| // Valid modes are: deployment, daemonset and statefulset. | |||
| // +optional | |||
| // +kubebuilder:validation:Enum=deployment;daemonSet;statefulSet; | |||
There was a problem hiding this comment.
This is a mistake. I'll remove the extra ;.
|
@pavolloffay I have fixed it. |
Description:
Link to tracking Issue(s):
Testing:
Documentation: