instrumentation/python: set OTEL_EXPORTER_OTLP_PROTOCOL to http/protobuf #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
force-pushed
the
python-set-otel-exporter-otlp-protocol
branch
2 times, most recently
from
5f1b8f2 to
6015543
Compare
|
I'm not able to sort out what's wrong with the e2e-tests failure but looks unrelated. |
|
@xrmx fixed that, e2e can be flaky at times. |
jaronoff97
approved these changes
Jul 26, 2024
xrmx
force-pushed
the
python-set-otel-exporter-otlp-protocol
branch
from
6f7ba8c to
f5b5c17
Compare
…gnal specific env vars Instead of setting the environment variable for each signal use the common one that it is also set by the distro.
TylerHelmuth
approved these changes
Jul 26, 2024
xrmx
force-pushed
the
python-set-otel-exporter-otlp-protocol
branch
from
f5b5c17 to
735d5ae
Compare
|
I don't understand what this mean: |
|
@xrmx it means the import statements at the top of the file are not arranged correctly into 3 sections. |
Was not that, the issue was that there were too many spaces in the const definitions before the equal sign 😅 |
iblancasa
approved these changes
Jul 29, 2024
swiatekm
approved these changes
Jul 30, 2024
pavolloffay
reviewed
Aug 5, 2024
xrmx
commented
Aug 5, 2024
|
Hello, can I do something to move this forward? BTW merged main and e2e tests failure looks unrelated. Thanks! |
TylerHelmuth
added
the
ready-to-merge
pavolloffay
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Instead of setting the environment variable for each specific signal use the common one that it is also the one that is set by the distro.
Link to tracking Issue(s):
Testing:
Added test case for the new environment variable set
Documentation:
None