Add ServiceAccount doc #2574
Merged
Add ServiceAccount doc #2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Sa <[email protected]>
pavolloffay
reviewed
Jan 29, 2024
| @@ -0,0 +1,16 @@ | |||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | |||
| change_type: 'enhancement' | |||
There was a problem hiding this comment.
Can we remove the entry. We are not adding any new feature in this patch
README.md
Outdated
| @@ -665,6 +665,55 @@ spec: | |||
| exporters: [debug] | |||
| ``` | |||
|
|
|||
| #### Using imagePullSecrets | |||
There was a problem hiding this comment.
This is being added under TA. It should rather belong to the general collector section.
README.md
Outdated
| mode: deployment | ||
| image: | ||
| serviceAccount: <service-account-name> | ||
| config: | |
There was a problem hiding this comment.
I would skip this section as it is irrelevant in this context
README.md
Outdated
| kubectl create secret docker-registry <secret-name> --docker-server=<registry name> \ | ||
| --docker-username=DUMMY_USERNAME --docker-password=DUMMY_DOCKER_PASSWORD \ | ||
| --docker-email=DUMMY_DOCKER_EMAIL | ||
|
|
There was a problem hiding this comment.
@pavolloffay , I made all the requested changes.
Signed-off-by: Yuri Sa <[email protected]>
jaronoff97
approved these changes
Jan 29, 2024
pavolloffay
approved these changes
Jan 30, 2024
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Add ServiceAccount doc Signed-off-by: Yuri Sa <[email protected]> * Add ServiceAccount doc Signed-off-by: Yuri Sa <[email protected]> --------- Signed-off-by: Yuri Sa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added documentation for use ServiceAccount imagePullSecrets
Link to tracking Issue:
Resolves #2521
Testing:
Documentation: