-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new operator capability to check if it has access to do an operation #2467
Conversation
cc @rashmichandrashekar :) |
This struct looks pretty small, I think we can do better. Maybe marshal it to yaml or json with an indent? Or at least display a single message with missing permissions in a list? |
I think the last option would be the most useful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great job!
…ion (open-telemetry#2467) * rbac pr testing * makefile convenience * Add test * add chlog * Add a comment * update to allow for policy rule checking * change package * lint fail * better formatting * don't use leading slash for empty group * add more detail for comment
Description:
Adds a new rbac package for checking if a given serviceaccount is able to do an RBAC gated action. This includes a warning for an upcoming target allocator capability (#2328) as an example ahead of that PRs merging.
Link to tracking Issue: closes #2426
Testing: unit tests were added, as well as manual testing in a kind cluster
Documentation: new admissions warnings!