add loki parser to parse servicePort from config #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
reviewed
Dec 13, 2023
| }, | ||
| }, | ||
| }, | ||
| } { |
There was a problem hiding this comment.
the formatting here is a bit odd... why have another {?
There was a problem hiding this comment.
This is where the actual for loop begins. Before that, it was only the array definition.
It is the same formatting as in the OTLP receiver
There was a problem hiding this comment.
ah i see, yeah i usually have only seen this in the test blocks so my brain didn't parse that correctly. Thanks for explaining!
jaronoff97
approved these changes
Dec 22, 2023
pavolloffay
approved these changes
Dec 22, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Co-authored-by: Jacob Aronoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add
LokiReceiverParserto parseservicePortfrom config.By default, only the Otel ports are extracted, parsed, then configured into the collector container's list of service ports.
This feature allows extracting loki ports (grpc:9095/http:3100, see default values) into the container's port list.
Link to tracking Issue:
Resolves #1825