Use openshift base domain if ingress hostname is missing #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
force-pushed
the
ocp-domain
branch
from
000c1e5 to
191cddb
Compare
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
pavolloffay
force-pushed
the
ocp-domain
branch
from
6a792c5 to
756ef72
Compare
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
|
@frzifus @jaronoff97 could you please review? |
frzifus
reviewed
Aug 28, 2023
| if params.Instance.Spec.Ingress.Hostname == "" { | ||
| domain, err := openshift.GetOpenShiftBaseDomain(context.Background(), params.Client) | ||
| if err != nil { | ||
| params.Recorder.Event(¶ms.Instance, "Error", "Normal", "Failed to get basedomain for Route.") |
There was a problem hiding this comment.
Does it make sense to return also an error in that case?
There was a problem hiding this comment.
That is a good question, if we error here the whole instance creation stops.
In the current implementation, the instance gets created, but the routes will fail, so I didn't change that.
There was a problem hiding this comment.
hm.. I assume failing early is good. May I ask, whats your thoughts on that @jaronoff97 ?
There was a problem hiding this comment.
hm.. I assume failing early is good. May I ask, whats your thoughts on that @jaronoff97 ?
For other resources, we follow the same approach: the instance is created, the "extra" resource is not but we log an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker image: docker.io/pavolloffay/opentelemetry-operator:dev-756ef72-1693233303
Updates: #1967
Updates: #1969