Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[instrumentation] Update to latest Go Instrumentation version #1740

Merged
merged 2 commits into from
May 16, 2023

Conversation

TylerHelmuth
Copy link
Member

No description provided.

@TylerHelmuth TylerHelmuth requested a review from a team May 15, 2023 17:39
@@ -30,7 +30,7 @@ autoinstrumentation-python=0.38b0
autoinstrumentation-dotnet=0.7.0

# Represents the current release of Go instrumentation.
autoinstrumentation-go=v0.2.0-alpha
autoinstrumentation-go=v0.2.1-alpha
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this should just be in the next release, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking through the RELEASE doc I'd agree with you. If we only bump the versions during the release and not before then this can wait.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versions can be updated in the main branch and I would also argue that it is preferred if more code changes are required.

The release process has to make sure that the latest available versions are used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm there are no code changes needed with this change, only the bump.

@TylerHelmuth TylerHelmuth mentioned this pull request May 16, 2023
@jaronoff97 jaronoff97 merged commit bc3ce30 into open-telemetry:main May 16, 2023
@TylerHelmuth TylerHelmuth deleted the update-go-version branch May 16, 2023 22:14
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants