-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unused default argument in Tracer #913
chore: remove unused default argument in Tracer #913
Conversation
A Tracer is always created by a TracerProvider and this one always passes it's config therefore no need to default in construtor.
Codecov Report
@@ Coverage Diff @@
## master #913 +/- ##
==========================================
- Coverage 94.49% 92.92% -1.57%
==========================================
Files 246 246
Lines 10898 11159 +261
Branches 1044 1091 +47
==========================================
+ Hits 10298 10370 +72
- Misses 600 789 +189
|
Tracers should not be created manually anyway so I think this is a good change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ry#913) Co-authored-by: Gerhard Stöbich <[email protected]>
A Tracer is always created by a TracerProvider and this one always passes it's config
therefore no need to default in constructor.