fix: @opentelemetry/metrics fails to run due to bad import #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
bg451,
dyladan,
markwolff,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
mayurkale22
commented
Mar 19, 2020
| @@ -28,7 +28,7 @@ import { | |||
| import { LabelSet } from './LabelSet'; | |||
| import { Batcher, UngroupedBatcher } from './export/Batcher'; | |||
| import { PushController } from './export/Controller'; | |||
| import { NoopExporter } from '../test/mocks/Exporter'; | |||
| import { NoopExporter } from './export/NoopExporter'; | |||
There was a problem hiding this comment.
Another option is to use ConsoleMetricExporter as a default metric exporter.
There was a problem hiding this comment.
or InMemoryMetricExporter similar to InMemorySpanExporter.
There was a problem hiding this comment.
I think no-op is better. We can create a more fancy version of no-op if a need arises later.
dyladan
approved these changes
Mar 19, 2020
| @@ -28,7 +28,7 @@ import { | |||
| import { LabelSet } from './LabelSet'; | |||
| import { Batcher, UngroupedBatcher } from './export/Batcher'; | |||
| import { PushController } from './export/Controller'; | |||
| import { NoopExporter } from '../test/mocks/Exporter'; | |||
| import { NoopExporter } from './export/NoopExporter'; | |||
There was a problem hiding this comment.
I think no-op is better. We can create a more fancy version of no-op if a need arises later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?