Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename scope to context #853

Merged
merged 6 commits into from
Mar 13, 2020
Merged

Rename scope to context #853

merged 6 commits into from
Mar 13, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Mar 12, 2020

Fixes #794

OlivierAlbertini
OlivierAlbertini approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayurkale22
Copy link
Member

Please resolve the conflicts.

@dyladan dyladan added this to the Beta milestone Mar 13, 2020
@mayurkale22 mayurkale22 added the Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Mar 13, 2020
obecny
obecny approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of changes, lgtm, question with regards to 2 files, it seems like 2 of them were nor renamed but deleted and added ?

packages/opentelemetry-context-async-hooks/test/AsyncHooksContextManager.test.ts
@@ -0,0 +1,290 @@
/*!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a new file ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a moved file but the git change detection isn't smart enough to figure that out because the whole package moved and the name also changed.

packages/opentelemetry-web/test/StackContextManager.test.ts
@@ -0,0 +1,198 @@
/*!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you just rename file ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a moved file but the git change detection isn't smart enough.

@dyladan dyladan merged commit 9a3fd7b into open-telemetry:master Mar 13, 2020
@dyladan dyladan deleted the context-rename branch March 13, 2020 19:01
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
@dyladan
Rename scope to context (open-telemetry#853)
63f4af5
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@arbiv
chore: Added contributors image to readme (open-telemetry#853)
08b5615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@OlivierAlbertini OlivierAlbertini OlivierAlbertini approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@obecny obecny obecny approved these changes

@bg451 bg451 Awaiting requested review from bg451

@markwolff markwolff Awaiting requested review from markwolff

@rochdev rochdev Awaiting requested review from rochdev

Assignees
No one assigned
Labels
Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Milestone
Beta
Development

Successfully merging this pull request may close these issues.

Rename Scope to Context
5 participants
@dyladan @mayurkale22 @obecny @vmarchaud @OlivierAlbertini