Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Leftover configs #850

Merged

Conversation

mayurkale22
Copy link
Member

@mayurkale22 mayurkale22 commented Mar 11, 2020

Leftovers from #816

@mayurkale22 mayurkale22 changed the title Add DEFAULT_SDK_REGISTRATION_CONFIG Remove Leftover configs Mar 11, 2020
@codecov-io
Copy link

codecov-io commented Mar 11, 2020

Codecov Report

Merging #850 into master will increase coverage by 1.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #850      +/-   ##
==========================================
+ Coverage   92.93%   94.44%   +1.51%     
==========================================
  Files         253      254       +1     
  Lines       11104    11027      -77     
  Branches     1064     1069       +5     
==========================================
+ Hits        10319    10415      +96     
+ Misses        785      612     -173
Impacted Files Coverage Δ
packages/opentelemetry-tracing/src/config.ts 100% <ø> (ø) ⬆️
...kages/opentelemetry-plugin-dns/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
...ckages/opentelemetry-core/src/common/NoopLogger.ts 80% <0%> (-3.34%) ⬇️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-plugin-dns/src/version.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-resources/src/constants.ts 100% <0%> (ø) ⬆️
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-plugin-redis/src/version.ts 100% <0%> (ø) ⬆️
...telemetry-plugin-grpc/test/utils/assertionUtils.ts 100% <0%> (ø) ⬆️
... and 40 more

@mayurkale22 mayurkale22 merged commit c842117 into open-telemetry:master Mar 11, 2020
@mayurkale22 mayurkale22 deleted the DEFAULT_SDK_REGISTRATION_CONFIG branch March 11, 2020 23:52
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants