Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK Resource #846
SDK Resource #846
Changes from all commits
bd9fa0d
83415d7
52bec49
a736f80
6a1ef77
28c3b0f
c2c6ca4
fd7b6b6
93e1e5c
afc65f7
09001af
3759126
2a48701
101d3c7
40e11c2
4c9c86a
08aa5e2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about making
resource
part of MeterConfig with default value either toResource.empty()
orResource.createTelemetrySDKResource()
? This way users (and independent developers) can customize the resource attributes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went with
Resource.createTelemetrySDKResource()
as the default. When we have resource auto detection, it will be updated to use that (e.g.Resource.detectAll()
or similar).