chore: add typing to propagator carrier #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dyladan
commented
Feb 6, 2020
dyladan
commented
- Adds typing where there was none before :)
dyladan
requested review from
bg451,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
mayurkale22
approved these changes
Feb 6, 2020
| @@ -407,7 +407,7 @@ export class HttpPlugin extends BasePlugin<Http> { | |||
| const span = plugin._startHttpSpan(operationName, spanOptions); | |||
| plugin._tracer | |||
| .getHttpTextFormat() | |||
| .inject(span.context(), Format.HTTP, options.headers); | |||
| .inject(span.context(), Format.HTTP, options.headers!); | |||
There was a problem hiding this comment.
ahh, earlier this worked due to unknown type.
Codecov Report
@@ Coverage Diff @@
## master #772 +/- ##
==========================================
+ Coverage 91.23% 92.37% +1.13%
==========================================
Files 234 134 -100
Lines 10855 4422 -6433
Branches 1023 411 -612
==========================================
- Hits 9904 4085 -5819
+ Misses 951 337 -614
|
mayurkale22
added
enhancement
markwolff
approved these changes
Feb 7, 2020
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.