Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unref jaeger socket to prevent process running indefinitely #715

Merged
merged 4 commits into from
Jan 24, 2020
+8 −2
Merged

fix: unref jaeger socket to prevent process running indefinitely #715

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
376c373
fix: unref jaeger socket to prevent process running indefinitely
dyladan Jan 21, 2020
7703f92
chore: fix lint
dyladan Jan 21, 2020
a99738e
Merge branch 'master' into unref-jaeger
dyladan Jan 22, 2020
1af3924
Merge branch 'master' into unref-jaeger
dyladan Jan 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/opentelemetry-exporter-jaeger/src/jaeger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,13 @@
* limitations under the License.
*/

import { SpanExporter, ReadableSpan } from '@opentelemetry/tracing';
import { ExportResult } from '@opentelemetry/base';
import * as jaegerTypes from './types';
import { NoopLogger } from '@opentelemetry/core';
import { ReadableSpan, SpanExporter } from '@opentelemetry/tracing';
import * as types from '@opentelemetry/types';
import { Socket } from 'dgram';
import { spanToThrift } from './transform';
import * as jaegerTypes from './types';

/**
* Format and sends span information to Jaeger Exporter.
Expand All @@ -40,6 +41,11 @@ export class JaegerExporter implements SpanExporter {
typeof config.flushTimeout === 'number' ? config.flushTimeout : 2000;

this._sender = new jaegerTypes.UDPSender(config);
if (this._sender._client instanceof Socket) {
// unref socket to prevent it from keeping the process running
this._sender._client.unref();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}

this._process = {
serviceName: config.serviceName,
tags: jaegerTypes.ThriftUtils.getThriftTags(tags),
Expand Down