chore(configuration): remove obsolete attribute limits TODO#6891
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6891 +/- ##
=======================================
Coverage 95.08% 95.09%
=======================================
Files 394 394
Lines 13997 13997
Branches 3224 3224
=======================================
+ Hits 13309 13310 +1
+ Misses 688 687 -1
🚀 New features to boost your workflow:
|
|
Hi @LarryHu0217 , thank you for your contribution! I'll review this PR this week, in the meantime make sure you add a changelog. Also, you added here and on a few other issues the phrase "No compensation requested.", this is an open source project, there is no compensation to be requested, so there is no need to comment that and also no expectation of receiving any monetary compensation :) |
|
Thanks for letting me know. I added the changelog and cleaned up the PR description. |
570b62b to
4700903
Compare
trentm
left a comment
There was a problem hiding this comment.
@LarryHu0217 I feel a little bad. I'm the one that added that "TODO" comment for this as part of the work in #6765.
However, from https://opentelemetry.io/docs/specs/otel/common/#exempt-entities in the spec:
Resource attributes SHOULD be exempt from the limits described above ...
So I think we should not make this change. We should remove the "// TODO(6842): handle attribute limits, if any" comment and close #6842 as wontfix.
4415264 to
1856b7c
Compare
|
Thanks for catching this. I updated the PR to remove only the obsolete TODO and dropped the attribute-limit implementation and related tests. Resource behavior is now unchanged. |
|
Could a maintainer add the |
|
Lint failure is unrelated. Link-checking is DoS'ing the opentelemetry.io site. |
|
Thanks for the quick turn around. |
17e4f8c
|
Thank you for your contribution @LarryHu0217! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
What changed
Remove the obsolete
TODO(6842)comment from resource attribute merging. No resource attribute limit behavior is added.Why
The OpenTelemetry specification says resource attributes should be exempt from the general attribute limits. Keeping the TODO implied behavior that should not be implemented, so this PR now removes only that misleading comment and leaves resource behavior unchanged.
Related to #6842.
Validation
experimental/packages/configuration/src/FileConfigFactory.tsgit diff --checkAI assistance disclosure
ChatGPT was used to assist with code exploration, implementation, and test preparation. I reviewed the changes and validation results.