fix(instrumentation,instrumentation-http): fix codecov under-reporting#6867
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6867 +/- ##
==========================================
- Coverage 95.58% 95.14% -0.45%
==========================================
Files 388 397 +9
Lines 13170 14248 +1078
Branches 3005 3296 +291
==========================================
+ Hits 12589 13556 +967
- Misses 581 692 +111 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
I found this while working on #6864. Coverage for
instrumentationandinstrumentation-httpwas under-reported on Codecov. Both packages run their CJS and ESM (and double-instr) suites as separatenycinvocations. By default eachnycrun cleans.nyc_outputbefore running and writes a report after, so the later run wiped the earlier run's data and the finalcoverage-final.jsonreflected only the last suite.Short description of the changes
--no-cleanto the follow-on test runs so raw coverage accumulates in.nyc_outputinstead of being wiped.nyc reportto thetestscript to emit the merged report Codecov consumes.--silentto the per-suite runs to suppress the partial intermediate reports.Type of change
How Has This Been Tested?
npm testin both packages and confirmed the resultingcoverage-final.jsonincludes coverage from all suites (CJS + ESM + double-instr) rather than only the final run.Checklist: